r232439 - GCOV: Expose the -coverage-exit-block-before-body flag in clang -cc1

[Justin Bogner]

David Blaikie <dblaikie at gmail.com> writes:
> On Mar 16, 2015 4:57 PM, "Justin Bogner" <mail at justinbogner.com> wrote:
>>
>> Author: bogner
>> Date: Mon Mar 16 18:52:21 2015
>> New Revision: 232439
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=232439&view=rev
>> Log:
>> GCOV: Expose the -coverage-exit-block-before-body flag in clang -cc1
>>
>> This exposes the optional exit block placement logic from r232438 as a
>> clang -cc1 option. There is a test on the llvm side, but there isn't
>> really a way to inspect the gcov options from clang to test it here as
>> well.
>
> I'm missing something probably - what's the benefit of that over just using
> -mllvm to pass this flag to llvm directly? (If I'm remembering how this stuff
> works)

I'm not sure - I was matching the -coverage-cfg-checksum and
-coverage-no-function-names-in-data CC1 options here. Maybe Nick has
thoughts?