[PATCH] libc++ iostream: Clean up standard I/O stream object creation in preparation for conditionalizing streams

Ed Schouten ed at nuxi.nl
Mon Mar 16 11:10:28 PDT 2015

In http://reviews.llvm.org/D8342#141422, @mclow.lists wrote:

> 2. Get rid (maybe) of the mbstates array - though I don't really see the motivation for that.

The reason why I removed the array and replaced it by separate mbstates is that once the change for making std::cin and std::cout optional hits the tree, the array will only be used partially. You could add some #ifdefs to reduce the size of the array and use different indexing based on whether std::cin/std::cout should be present, but that makes things even worse.

Let me split this change up even further.



More information about the cfe-commits mailing list