[PATCH] Adding SmallString support to Twine

PaweĊ‚ Bylica chfast at gmail.com
Mon Mar 16 01:59:03 PDT 2015


================
Comment at: tools/clang/lib/Sema/CodeCompleteConsumer.cpp:254
@@ -253,2 +253,3 @@
 
-const char *CodeCompletionAllocator::CopyString(StringRef String) {
+const char *CodeCompletionAllocator::CopyString(const Twine &T) {
+  SmallString<128> Data;
----------------
I liked the argument name `String` better than `T`. I know the type has changed but `CopyString` copies strings.

http://reviews.llvm.org/D6372

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list