[PATCH] Add support for armv6k subtarget

Vinicius Tinti viniciustinti at gmail.com
Sat Mar 14 13:14:30 PDT 2015


================
Comment at: lib/Basic/Targets.cpp:4181
@@ -4180,3 +4180,3 @@
         .Case("arm1136j-s", "6J")
-        .Cases("arm1176jz-s", "arm1176jzf-s", "6ZK")
-        .Cases("arm1136jf-s", "mpcorenovfp", "mpcore", "6K")
+        .Case("arm1136jf-s", "6")
+        .Cases("mpcorenovfp", "mpcore", "6K")
----------------
rengolin wrote:
> The problem about ARMv6KZ is here. Was this ever used? I think not. Can we get rid of it for a more correct option, I think so. Anyone disagree?
I would vote to keep and only map it for ARMv6K unless one can guarantee that this is absolutely internal and do not go to external tools or libraries.

================
Comment at: lib/Driver/ToolChains.cpp:113
@@ -112,2 +112,3 @@
   return llvm::StringSwitch<const char*>(Value)
-    .Case("armv6k", "armv6")
+    .Case("armv6", "armv6")
+    .Case("armv6k", "armv6k")
----------------
tinti wrote:
> rengolin wrote:
> > Isn't there a default to keep the same name?
> I will test.
> 
> But since there was an armv6m -> armv6m right below I believed it was needed.
As Tim said. In fact this is Mach specific we do not need to change none of the lines in lib/Driver/ToolChains.cpp. This file is weird.

http://reviews.llvm.org/D8127

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list