[PATCH] libc++: Add option to disable access to the global filesystem namespace

[Jonathan Roelofs]

REPOSITORY
  rL LLVM

================
Comment at: libcxx/trunk/include/__config:731
@@ +730,3 @@
+// used, as they attempt to access the global filesystem namespace.
+#ifdef __CloudABI__
+#define _LIBCPP_HAS_NO_GLOBAL_FILESYSTEM_NAMESPACE
----------------
EricWF wrote:
> Where do we get the definition for `__CloudABI__` from?
Compiler provides it, just like `__APPLE__` and all the others.

================
Comment at: libcxx/trunk/test/libcxx/test/format.py:63
@@ -62,1 +62,3 @@
 
+        if test.config.unsupported:
+            return (lit.Test.UNSUPPORTED,
----------------
EricWF wrote:
> I don't think we should be using this. Why not put the metadata into the tests?
This is how the tests in llvm/test/CodeGen work. I think it cleans things up **significantly**. I view it as a mistake that I did the libcpp-has-no-threads UNSUPPORTEDs this way.... it's a bit painful to maintain them.

================
Comment at: libcxx/trunk/test/std/input.output/file.streams/c.files/no.global.filesystem.namespace/fopen.fail.cpp:8
@@ +7,3 @@
+//
+//===----------------------------------------------------------------------===//
+
----------------
EricWF wrote:
> Add `// UNSUPPORTED: libcpp-has-no-global-filesystem-namespace`
No, unless you meant `// REQUIRES: libcpp-has-no-global-filesystem-namespace`.

================
Comment at: libcxx/trunk/test/std/input.output/file.streams/c.files/no.global.filesystem.namespace/rename.fail.cpp:9
@@ +8,3 @@
+//===----------------------------------------------------------------------===//
+
+#include <cstdio>
----------------
EricWF wrote:
> Add `// UNSUPPORTED: libcpp-has-no-global-filesystem-namespace`
No, unless you meant `// REQUIRES: libcpp-has-no-global-filesystem-namespace`.

http://reviews.llvm.org/D8194

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/