FW: [OpenCL][Patch] This patch adds OpenCL checks in OpenCL address space conversion rules

Pekka Jääskeläinen pekka.jaaskelainen at tut.fi
Wed Mar 11 11:30:13 PDT 2015


LGTM except lhsPtr should start with a capital letter? ;]

On 02/17/2015 12:40 PM, Anastasia Stulova wrote:
> Ping!
>
> *From:*cfe-commits-bounces at cs.uiuc.edu [mailto:cfe-commits-bounces at cs.uiuc.edu]
> *On Behalf Of *Anastasia Stulova
> *Sent:* 12 February 2015 17:27
> *To:* cfe-commits at cs.uiuc.edu
> *Subject:* [OpenCL][Patch] This patch adds OpenCL checks in OpenCL address space
> conversion rules
>
> Recently committed OpenCL specific address space conversion rules broke Clang
> address space extension for C.
>
> This patch fixes the problem by checking for OpenCL and adds the missing test
> code that identifies this failure.
>
> Thanks to Manuel Jacob who spotted this problem!
>
> Regards,
>
> Anastasia



More information about the cfe-commits mailing list