[PATCH] [PPC64] Add 64-bit Vector Integer Arithmetic Instructions

[hfinkel at anl.gov]

Aside from some formatting issues, LGTM.


================
Comment at: lib/Headers/altivec.h:3842
@@ +3841,3 @@
+}
+
+#endif
----------------
Remove blank line.

================
Comment at: lib/Headers/altivec.h:3955
@@ +3954,3 @@
+}
+
+#endif
----------------
Remove blank line.

================
Comment at: lib/Headers/altivec.h:11253
@@ +11252,3 @@
+{
+  return __builtin_altivec_vcmpgtsd_p(__CR6_EQ, (vector signed long long)__b, __a);
+}
----------------
Line too long.

================
Comment at: lib/Headers/altivec.h:11280
@@ +11279,3 @@
+{
+  return __builtin_altivec_vcmpgtud_p(__CR6_EQ, __b, (vector unsigned long long)__a);
+}
----------------
Line too long.

================
Comment at: lib/Headers/altivec.h:11447
@@ +11446,3 @@
+{
+  return __builtin_altivec_vcmpgtsd_p(__CR6_LT, __a, (vector signed long long)__b);
+}
----------------
Line too long.

================
Comment at: lib/Headers/altivec.h:11474
@@ +11473,3 @@
+{
+  return __builtin_altivec_vcmpgtud_p(__CR6_LT, (vector unsigned long long)__a, __b);
+}
----------------
Line too long.

================
Comment at: lib/Headers/altivec.h:11656
@@ +11655,3 @@
+{
+  return __builtin_altivec_vcmpgtsd_p(__CR6_EQ, __a, (vector signed long long)__b);
+}
----------------
Line too long.

================
Comment at: lib/Headers/altivec.h:11677
@@ +11676,3 @@
+{
+  return __builtin_altivec_vcmpgtud_p(__CR6_EQ, (vector unsigned long long)__a, __b);
+}
----------------
Line too long.

================
Comment at: lib/Headers/altivec.h:11851
@@ +11850,3 @@
+{
+  return __builtin_altivec_vcmpgtsd_p(__CR6_LT, (vector signed long long)__b, __a);
+}
----------------
Line too long.

================
Comment at: lib/Headers/altivec.h:11872
@@ +11871,3 @@
+{
+  return __builtin_altivec_vcmpgtud_p(__CR6_LT, __b, (vector unsigned long long)__a);
+}
----------------
Line too long.

================
Comment at: lib/Headers/altivec.h:12055
@@ +12054,3 @@
+{
+  return __builtin_altivec_vcmpequd_p(__CR6_EQ, __a, (vector signed long long)__b);
+}
----------------
Line too long.

================
Comment at: lib/Headers/altivec.h:12309
@@ +12308,3 @@
+{
+  return __builtin_altivec_vcmpequd_p(__CR6_EQ_REV, __a, (vector signed long long)__b);
+}
----------------
Line too long.

================
Comment at: lib/Headers/altivec.h:12509
@@ +12508,3 @@
+{
+  return __builtin_altivec_vcmpgtsd_p(__CR6_LT_REV, (vector signed long long)__b, __a);
+}
----------------
Line too long.

================
Comment at: lib/Headers/altivec.h:12530
@@ +12529,3 @@
+{
+  return __builtin_altivec_vcmpgtud_p(__CR6_LT_REV, __b, (vector unsigned long long)__a);
+}
----------------
Line too long.

================
Comment at: lib/Headers/altivec.h:12708
@@ +12707,3 @@
+{
+  return __builtin_altivec_vcmpgtsd_p(__CR6_EQ_REV, __a, (vector signed long long)__b);
+}
----------------
Line too long.

================
Comment at: lib/Headers/altivec.h:12909
@@ +12908,3 @@
+{
+  return __builtin_altivec_vcmpgtsd_p(__CR6_LT_REV, __a, (vector signed long long)__b);
+}
----------------
Line too long.

================
Comment at: lib/Headers/altivec.h:13109
@@ +13108,3 @@
+{
+  return __builtin_altivec_vcmpgtsd_p(__CR6_EQ_REV, (vector signed long long)__b, __a);
+}
----------------
Line too long.

================
Comment at: lib/Headers/altivec.h:13332
@@ +13331,3 @@
+{
+  return __builtin_altivec_vcmpequd_p(__CR6_LT_REV, __a, (vector signed long long)__b);
+}
----------------
Line too long.

================
Comment at: lib/Sema/DeclSpec.cpp:992
@@ -991,2 +991,3 @@
       // vector bool long long requires VSX support.
-      if ((TypeSpecWidth == TSW_longlong) && (!PP.getTargetInfo().hasFeature("vsx")))
+      if ((TypeSpecWidth == TSW_longlong) && (!PP.getTargetInfo().hasFeature("vsx")) &&
+          (!PP.getTargetInfo().hasFeature("power8-vector")))
----------------
Line too long. (it was before too it seems, but you can fix it here).

================
Comment at: test/CodeGen/builtins-ppc-p8vector.c:6
@@ +5,3 @@
+
+
+vector int vi = { -1, 2, -3, 4 };
----------------
Only need one blank line here.

http://reviews.llvm.org/D8041

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/