[PATCH] libc++: Add support for arc4random() to random_device.

Ed Schouten ed at nuxi.nl
Mon Mar 9 05:32:51 PDT 2015


Hi JF,

In http://reviews.llvm.org/D8134#136002, @jfb wrote:

> arc4random was broken for a short while on FreeBSD: http://lwn.net/Articles/633805/rss
>  Not much can be done from libc++, but I'd avoid using it for a while on that platform so we can be reasonably certain they're fixed.


Just for the record, as Ed Maste (emaste at FreeBSD.org) reported, arc4random() was only broken in the development track of FreeBSD. There shouldn't be any reason to not use it on supported versions of FreeBSD. For now I'll only enable this on CloudABI (because it's needed to make libc++ build).

I've updated the patch to check for /dev/urandom on all architectures now. Be sure to let me know what you think.

Thanks,
Ed


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D8134

Files:
  include/__config
  include/random
  src/random.cpp
  test/std/numerics/rand/rand.device/ctor.pass.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8134.21480.patch
Type: text/x-patch
Size: 6306 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150309/9c1f2142/attachment.bin>


More information about the cfe-commits mailing list