[PATCH] Restrict -Winconsistent-missing-override warnings on class templates with dependent bases

David Blaikie dblaikie at gmail.com
Fri Mar 6 09:36:25 PST 2015


Would it be plausible to check this on templates directly, rather than on
their instantiations? This would be less work in the case of multiple
instantiations, avoid redundant diagnostics, fail on templates without
instantiations rather than creating a lurking failure, and we might even
get all the "dependent" tests for free - because we wouldn't be able to
look through the dependent types at all.

- David

On Wed, Feb 25, 2015 at 10:39 AM, jahanian <fjahanian at apple.com> wrote:

>
> This patch restricts issuing -Winconsistent-missing-override when dealing
> with
> class template with dependent bases and dependent methods.
> Fixed pr22582 rdar://19917107.
> Please review.
>
> - Fariborz
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150306/aeaacb38/attachment.html>


More information about the cfe-commits mailing list