[PATCH] [PPC64] Add 64-bit Vector Integer Arithmetic Instructions

Nemanja Ivanovic nemanja.i.ibm at gmail.com
Wed Mar 4 08:35:37 PST 2015


================
Comment at: lib/Headers/altivec.h:1533
@@ -1503,1 +1532,3 @@
 
+/* vec_vcmpgtsd */
+#ifdef __POWER8_VECTOR__
----------------
kbarton wrote:
> hfinkel wrote:
> > nemanjai wrote:
> > > I am just curious why we are adding these. The ABI document specifies the [byte, halfword, word] versions of these as "deprecated and provided for compatibility only". Furthermore, it does not list the doubleword versions of these.
> > Generally speaking, a deprecated facility in a standard still needs to be provided by an implementation. However, if these are deprecated, we should add __attribute__((deprecated)) to these.
> > 
> I didn't realize these were deprecated in the ABI document. The corresponding byte, halfword, and word versions have not been marked as deprecated, so I added these for consistency.
> 
> I'll add the deprecated attribute to these now, and check the ABI document to see if others should be marked as deprecated also. 
I think I was a bit unclear. The existing ones are deprecated, the new one is not listed in the ABI.

================
Comment at: lib/Headers/altivec.h:11513
@@ +11512,3 @@
+#ifdef __POWER8_VECTOR__
+static long long __ATTRS_o_ai
+vec_all_ge(vector long long __a, vector long long __b)
----------------
Same comment about the return type.

================
Comment at: lib/Headers/altivec.h:11708
@@ +11707,3 @@
+#ifdef __POWER8_VECTOR__
+static long long __ATTRS_o_ai
+vec_all_gt(vector long long __a, vector long long __b)
----------------
Return type again.

================
Comment at: lib/Headers/altivec.h:11912
@@ +11911,3 @@
+#ifdef __POWER8_VECTOR__
+static long long __ATTRS_o_ai
+vec_all_le(vector long long __a, vector long long __b)
----------------
Return type. I'll stop these comments, but basically the return type for all of the "compare all/any elements" builtins.

http://reviews.llvm.org/D8041

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list