r231244 - [IAS] Teach -cc1as about the 'target-abi' option.

Toma Tabacu toma.tabacu at imgtec.com
Wed Mar 4 06:24:25 PST 2015


Author: tomatabacu
Date: Wed Mar  4 08:24:25 2015
New Revision: 231244

URL: http://llvm.org/viewvc/llvm-project?rev=231244&view=rev
Log:
[IAS] Teach -cc1as about the 'target-abi' option.

Summary:
When using the IAS from clang, the 'target-abi' option gets passed to cc1as, but cc1as doesn't know about it and gives an "unknown argument" error.

This is fixed by adding the 'CC1AsOption' flag to the 'target-abi' option in CC1Options.td.

Reviewers: atanasyan, echristo, dsanders

Reviewed By: dsanders

Subscribers: cfe-commits

Differential Revision: http://reviews.llvm.org/D7903

Added:
    cfe/trunk/test/Driver/target-abi-cc1as.s
Modified:
    cfe/trunk/include/clang/Driver/CC1Options.td

Modified: cfe/trunk/include/clang/Driver/CC1Options.td
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/CC1Options.td?rev=231244&r1=231243&r2=231244&view=diff
==============================================================================
--- cfe/trunk/include/clang/Driver/CC1Options.td (original)
+++ cfe/trunk/include/clang/Driver/CC1Options.td Wed Mar  4 08:24:25 2015
@@ -25,11 +25,11 @@ def target_feature : Separate<["-"], "ta
   HelpText<"Target specific attributes">;
 def triple : Separate<["-"], "triple">,
   HelpText<"Specify target triple (e.g. i686-apple-darwin9)">;
+def target_abi : Separate<["-"], "target-abi">,
+  HelpText<"Target a particular ABI type">;
 
 }
 
-def target_abi : Separate<["-"], "target-abi">,
-  HelpText<"Target a particular ABI type">;
 def target_linker_version : Separate<["-"], "target-linker-version">,
   HelpText<"Target linker version">;
 def triple_EQ : Joined<["-"], "triple=">, Alias<triple>;

Added: cfe/trunk/test/Driver/target-abi-cc1as.s
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/target-abi-cc1as.s?rev=231244&view=auto
==============================================================================
--- cfe/trunk/test/Driver/target-abi-cc1as.s (added)
+++ cfe/trunk/test/Driver/target-abi-cc1as.s Wed Mar  4 08:24:25 2015
@@ -0,0 +1,5 @@
+// Check if -cc1as knows about the 'target-abi' argument.
+
+// RUN: %clang -cc1as -triple mips--linux-gnu -filetype obj -target-cpu mips32 -target-abi o32 %s 2>&1 | \
+// RUN:   FileCheck --check-prefix=ABI-O32 %s
+// ABI-O32-NOT: clang -cc1as: error: unknown argument: '-target-abi'





More information about the cfe-commits mailing list