[PATCH] [libcxx] Add support for linking libc++ against a static ABI library.

Eric Fiselier eric at efcs.ca
Mon Mar 2 15:09:28 PST 2015


================
Comment at: lib/CMakeLists.txt:41
@@ -40,1 +40,3 @@
 
+set(libraries "")
+if (LIBCXX_ENABLE_STATIC_ABI_LIBRARY)
----------------
EricWF wrote:
> compnerd wrote:
> > Can you add this in side of a check for the linker type?  The options are very GNU centric.
> Sounds like a good change. I'll look into it.
To comment on this further. The correct thing to do would be to use `find_library` with the static library name. However there are some consumers of libc++ that depend on libc++'s CMake not requiring that the library be found at configuration time since it will not yet exist.

This is also the reason why use use `LIBCXX_CXX_ABI_LIBRARY_PATH` to supply the library's directory and not the full path of the library file.
I'm hoping to change this in future.

http://reviews.llvm.org/D8017

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list