[PATCH] Refactor: Move llvm clang-tidy checks to namespace clang::tidy::llvm

Alexander Kornienko alexfh at google.com
Mon Mar 2 04:39:14 PST 2015


Looks good! Thanks!

I'll commit the patch for you.


================
Comment at: clang-tidy/llvm/IncludeOrderCheck.cpp:50
@@ -48,3 +49,3 @@
   Compiler.getPreprocessor().addPPCallbacks(
-      llvm::make_unique<IncludeOrderPPCallbacks>(*this,
+      ::llvm::make_unique<IncludeOrderPPCallbacks>(*this,
                                                  Compiler.getSourceManager()));
----------------
Wow, just one case of compiler being confused with another namespace llvm ;)

================
Comment at: clang-tidy/llvm/LLVMTidyModule.cpp:36
@@ -32,3 +35,3 @@
 // Register the LLVMTidyModule using this statically initialized variable.
-static ClangTidyModuleRegistry::Add<LLVMModule> X("llvm-module",
-                                                  "Adds LLVM lint checks.");
+static ClangTidyModuleRegistry::Add<llvm::LLVMModule>
+    X("llvm-module", "Adds LLVM lint checks.");
----------------
I'd put it inside namespace llvm to avoid the need to qualify LLVMModule.

http://reviews.llvm.org/D7995

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list