[PATCH] Fix codegen for virtual methods that are (re-) exported from multiple modules.

Richard Smith richard at metafoo.co.uk
Mon Feb 23 16:22:43 PST 2015


I'm curious how this was failing -- all four places you changed appear to be walking over the method declarations that are lexically within the class definitions, so they should all see the same set of declarations. Is there some other source of map keys that uses the canonical declaration instead? In any case, using the canonical declaration as the key seems like a good idea.

Is there any reason not to put all the module definitions in the same module map file in your test case? The `use` directives also seem redundant, since this isn't a test of `-fmodules-decluse`.


http://reviews.llvm.org/D7830

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list