[PATCH] Improve robustness of dependency-generation-crash.c test.

Matthias Braun matze at braunis.de
Fri Feb 20 10:47:39 PST 2015


ping.

> On Feb 13, 2015, at 11:28 AM, Matthias Braun <matze at braunis.de> wrote:
> 
> Hi mcrosier,
> 
> The test wants to provoke a failure when opening the output file.
> Using chmod 0 on the output file does not work reliably on all
> filesystems or when running the test as root.
> Change the test to use a nonexistant directory instead.
> 
> REPOSITORY
>  rL LLVM
> 
> http://reviews.llvm.org/D7620
> 
> Files:
>  test/Frontend/dependency-generation-crash.c
> 
> Index: test/Frontend/dependency-generation-crash.c
> ===================================================================
> --- test/Frontend/dependency-generation-crash.c
> +++ test/Frontend/dependency-generation-crash.c
> @@ -1,7 +1,4 @@
> -// RUN: touch %t
> -// RUN: chmod 0 %t
> -// RUN: not %clang_cc1 -E -dependency-file bla -MT %t -MP -o %t -x c /dev/null 2>&1 | FileCheck %s
> -// RUN: rm -f %t
> +// RUN: not %clang_cc1 -E -dependency-file bla -MT /thisX/doesXX/not/exist/bla.o -MP -o /thisX/doesXX/not/exist/bla.o -x c /dev/null 2>&1 | FileCheck %s
> 
> // CHECK: error: unable to open output file
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> <D7620.19911.patch>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits





More information about the cfe-commits mailing list