[PATCH] [Headers] Add tests for _mm256_insert_epi64 and fix its definition

H.J. Lu hjl.tools at gmail.com
Thu Feb 19 05:16:33 PST 2015


On Wed, Feb 18, 2015 at 7:04 PM, Filipe Cabecinhas
<filcab+llvm.phabricator at gmail.com> wrote:
> REPOSITORY
>   rL LLVM
>
> http://reviews.llvm.org/D7179
>
> Files:
>   cfe/trunk/lib/Headers/avxintrin.h
>   cfe/trunk/test/CodeGen/avx-builtins.c
>
> Index: cfe/trunk/lib/Headers/avxintrin.h
> ===================================================================
> --- cfe/trunk/lib/Headers/avxintrin.h
> +++ cfe/trunk/lib/Headers/avxintrin.h
> @@ -514,7 +514,7 @@
>
>  #ifdef __x86_64__
>  static __inline __m256i __attribute__((__always_inline__, __nodebug__))
> -_mm256_insert_epi64(__m256i __a, int __b, int const __imm)
> +_mm256_insert_epi64(__m256i __a, long __b, int const __imm)
                                                          ^^^^^^^
"long" is incorrect here.  It should be long long, like all other
_xxx_epi64 intrinsis
since long is 32-bit for x32.


-- 
H.J.



More information about the cfe-commits mailing list