r229719 - Driver: Fix use of dangling std::string temporary
hans at chromium.org
Wed Feb 18 13:05:31 PST 2015
On Wed, Feb 18, 2015 at 10:56 AM, Benjamin Kramer <benny.kra at gmail.com> wrote:
> On Wed, Feb 18, 2015 at 7:45 PM, Benjamin Kramer
> <benny.kra at googlemail.com> wrote:
>> Author: d0k
>> Date: Wed Feb 18 12:45:54 2015
>> New Revision: 229719
>> URL: http://llvm.org/viewvc/llvm-project?rev=229719&view=rev
>> Driver: Fix use of dangling std::string temporary
>> What's going on here is that the ternary operator produces a std::string rvalue
>> that the StringRef points to. I'd hoped bugs like this were a thing of the past
>> with our asan testing but apparently this code path is only used when LLVM is
>> configured with a custom --with-c-include-dirs setting.
>> Unbreaks bootstrapping with GCC5 on Fedora (PR22625), patch by Jonathan Wakely!
> this should be safe for 3.6, can you squeeze it in?
Merged in r229746.
More information about the cfe-commits