[clang/18432] Fix friend decl & default arg

Nathan Sidwell nathan at acm.org
Wed Feb 18 09:33:36 PST 2015

On 02/17/15 21:35, Richard Smith wrote:
> Sorry for the delay. The patch looks good, other than some style issues:

> No spaces before ().
Damn, I checked so carefully ...

> Please add braces around this 'if', since its body contains many lines.

> test/CXX/dcl.decl/dcl.meaning/dcl.fct.default/p9.cpp
> I'm not really sure what part of p9 this is testing; it seems more to be a test
> of p4, where inheritance of default arguments is specified.

Ah, I'd not understood the naming convention here.  I've moved that code into 

tested on x86_64-linux, ok?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 18432-2.patch
Type: text/x-patch
Size: 3970 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150218/9a94f68d/attachment.bin>

More information about the cfe-commits mailing list