[PATCH] clang-format: Space and triple angle braces

Daniel Jasper djasper at google.com
Wed Feb 18 02:11:39 PST 2015


I think that this is basically good to go. Do you have commit access?


================
Comment at: lib/Format/Format.cpp:665
@@ +664,3 @@
+      // Merge <,<,eof to <<,eof
+      if (Tokens.back()->Tok.is(tok::eof)) {
+        auto &eof = Tokens.back();
----------------
Use early exit.

================
Comment at: lib/Format/Format.cpp:681
@@ +680,3 @@
+
+    SmallVectorImpl<FormatToken *>::const_iterator First = Tokens.end() - 4;
+    if (First[3]->is(tok::less) || First[2]->isNot(tok::less) ||
----------------
Maybe just use "auto" here.

http://reviews.llvm.org/D6800

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list