r229204 - CodeGen: Correctly convert atomic bool from i8 to i1

David Majnemer david.majnemer at gmail.com
Tue Feb 17 18:33:34 PST 2015


Should be fixed with r229617.

On Tue, Feb 17, 2015 at 10:25 AM, Ulrich Weigand <Ulrich.Weigand at de.ibm.com>
wrote:

>
> David Majnemer wrote:
>
> >+// CHECK: %[[load:.*]] = load atomic i8* @b seq_cst, align 1
>
> This test now fails on SystemZ, because all global variables are aligned to
> at least 2, and thus the "align 1" doesn't match.
>
> Is there a reason the test needs to verify the alignment?  If so, we'd have
> to do something like in the c-strings.c test case.  Otherwise, it would be
> simplest to just remove the check for "align 1".
>
>
> Mit freundlichen Gruessen / Best Regards
>
> Ulrich Weigand
>
> --
>   Dr. Ulrich Weigand | Phone: +49-7031/16-3727
>   STSM, GNU/Linux compilers and toolchain
>   IBM Deutschland Research & Development GmbH
>   Vorsitzende des Aufsichtsrats: Martina Koederitz | Geschäftsführung: Dirk
> Wittkopp
>   Sitz der Gesellschaft: Böblingen | Registergericht: Amtsgericht
> Stuttgart, HRB 243294
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150217/608b83b7/attachment.html>


More information about the cfe-commits mailing list