r229526 - Remove the ABI from the target features. It's obsoleted by

Eric Christopher echristo at gmail.com
Tue Feb 17 12:20:38 PST 2015


As to why this is hard to test at the moment: We don't put the default
feature string anywhere into the module or the command line where it's
possible to be inspected. With Duncan's under review patch to have a module
level default attribute string for functions we might have noticed that
this was in there. Otherwise the only way you'd tell would be to invoke the
backend for something.

-eric

On Tue Feb 17 2015 at 12:12:46 PM Eric Christopher <echristo at gmail.com>
wrote:

> Author: echristo
> Date: Tue Feb 17 13:51:15 2015
> New Revision: 229526
>
> URL: http://llvm.org/viewvc/llvm-project?rev=229526&view=rev
> Log:
> Remove the ABI from the target features. It's obsoleted by
> the -target-abi use and those features don't exist anymore.
>
> Modified:
>     cfe/trunk/lib/Basic/Targets.cpp
>
> Modified: cfe/trunk/lib/Basic/Targets.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/
> Targets.cpp?rev=229526&r1=229525&r2=229526&view=diff
> ============================================================
> ==================
> --- cfe/trunk/lib/Basic/Targets.cpp (original)
> +++ cfe/trunk/lib/Basic/Targets.cpp Tue Feb 17 13:51:15 2015
> @@ -1161,9 +1161,6 @@ void PPCTargetInfo::getDefaultFeatures(l
>      .Default(false);
>
>    Features["qpx"] = (CPU == "a2q");
> -
> -  if (!ABI.empty())
> -    Features[ABI] = true;
>  }
>
>  bool PPCTargetInfo::hasFeature(StringRef Feature) const {
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150217/5167428b/attachment.html>


More information about the cfe-commits mailing list