[PATCH] [OPENMP] Codegen for "#pragma omp atomic write"

Alexey Bataev a.bataev at hotmail.com
Mon Feb 16 00:10:38 PST 2015


Yes, of course, just this patch was prepared before last update for 
atomics. I'll update patch for sure.

Best regards,

Alexey Bataev
=============

Software Engineer
Intel Compiler Team

16.02.2015 10:58, David Majnemer пишет:

> ================

>  Comment at: lib/CodeGen/CGStmtOpenMP.cpp:859

>  @@ +858,3 @@

>  +  else

>  +    CGF.EmitAtomicStore(ExprRValue, XLValue, /*isInit=*/false);

>  +  // OpenMP, 2.12.6, atomic Construct

> 

> - Shouldn't you use `monotonic` ordering if the `omp write` isn't `seq_cst`?

> 

>   http://reviews.llvm.org/D7369

> 

>   EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/



http://reviews.llvm.org/D7369

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list