[PATCH] [libcxxabi] Fix -Werror build for 32-bit non-ARM.

Dan Albert danalbert at google.com
Sat Feb 14 11:43:12 PST 2015


In http://reviews.llvm.org/D7419#123785, @rengolin wrote:

> The idea of making this header public may be worrying, if we end up requiring the user to include it. If this is just a matter of compiler-logic, than it should be fine.


The user will never have to include it manually. It's the job of each header to make sure it is included when needed. I've turned on `-Wundef` to try to keep us honest about that.


================
Comment at: src/Unwind/Unwind-EHABI.h:16
@@ +15,3 @@
+
+#if LIBCXXABI_ARM_EHABI
+
----------------
rengolin wrote:
> danalbert wrote:
> > rengolin wrote:
> > > Is this duplication intended?
> > Bad merge after splitting/rebasing my change. It was fixed right after in a follow up patch.
> I can't see it. Has this change been merged already?
https://github.com/llvm-mirror/libcxxabi/commit/8906bdd7f337749838f9c310e3bb913715c4d12f

http://reviews.llvm.org/D7419

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list