[PATCH] Teach llvm-lit about ENABLE_BACKTRACES

[Pete Cooper]

Hi Kristof

Oops, thanks for catching that. Fixed in r228870.

Pete
> On Feb 11, 2015, at 11:22 AM, Kristof Beyls <kristof.beyls at arm.com> wrote:
> 
> Hi Pete,
>  
> It seems you forgot to add a comma when you merged the REQUIRES lines, and now these tests never run,
> even when backtraces are enabled.
>  
> index 8b61b75..5fca8d8 100644
> --- a/test/Analysis/crash-trace.c
> +++ b/test/Analysis/crash-trace.c
> @@ -2,7 +2,8 @@
> // REQUIRES: crash-recovery
>  
> // FIXME: CHECKs might be incompatible to win32.
> -// REQUIRES: shell
> +// Stack traces also require back traces.
> +// REQUIRES: shell backtrace
>  
> I think this needs a comma between “shell” and “backtrace” as otherwise lit is parsing this as the “shell backtrace” feature.
>  
> diff --git a/test/Parser/crash-report.c b/test/Parser/crash-report.c
> index 92bc9ba..840a2a5 100644
> --- a/test/Parser/crash-report.c
> +++ b/test/Parser/crash-report.c
> @@ -2,7 +2,8 @@
> // REQUIRES: crash-recovery
>  
> // FIXME: CHECKs might be incompatible to win32.
> -// REQUIRES: shell
> +// Stack traces also require back traces.
> +// REQUIRES: shell backtrace
>  
> Same here.
>  
> Thanks,
>  
> Kristof
>  
> From: cfe-commits-bounces at cs.uiuc.edu [mailto:cfe-commits-bounces at cs.uiuc.edu] On Behalf Of Pete Cooper
> Sent: 10 February 2015 19:57
> To: Chandler Carruth
> Cc: Owen Anderson; Clang Commits
> Subject: Re: [PATCH] Teach llvm-lit about ENABLE_BACKTRACES
>  
>  
>> On Feb 10, 2015, at 11:50 AM, Chandler Carruth <chandlerc at google.com <mailto:chandlerc at google.com>> wrote:
>>  
>> This seems like a generally good thing to do if we're testing backtraces.
>>  
>> Do you want to merge the REQUIRES lines? I don't feel strongly either way.
> Didn’t know we could.  Thats useful.  I merged them and retested that it still works.
> 
>  
> Feel free to commit whenever.
> Thanks.  Its r228735
>  
> Pete
> 
>  
> On Tue, Feb 10, 2015 at 11:13 AM, Pete Cooper <peter_cooper at apple.com <mailto:peter_cooper at apple.com>> wrote:
> Hi Chandler, Owen
> 
> In your patches to LLVM which changed ThreadLocal and PrettyStackTrace, we ended up requiring ENABLE_BACKTRACES for PrettyStackTrace.
> 
> Trouble is, clang has 2 tests which check for the pretty stack trace on crashes.  This patch teaches lit about the ENABLE_BACKTRACES option, and updates those 2 tests to use that option.  Without this patch, clang fails to pass llvm-lit without back traces.
> 
> Thanks,
> Pete
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150211/03e1eea9/attachment.html>