[PATCH] Change how we deal with (implicit) -fno-rtti + -fsanitize=vptr

Richard Smith richard at metafoo.co.uk
Mon Feb 9 19:38:49 PST 2015


I don't think this is the right approach; the `-fsanitize=` setting deliberately doesn't affect whether RTTI is enabled, and I don't think we should change that. I think we should do the following:

- If `-fsanitize=vptr` is explicitly specified and RTTI is disabled, we should issue an error.
- If `-fsanitize=vptr` is implied by some sanitizer group (such as `-fsanitize=undefined`) and RTTI is disabled, we should not enable the vptr sanitizer (perhaps with a warning).

That presumably means handling this when we parse the sanitizer arguments, which might require us to reorder the processing of the arguments a bit.


http://reviews.llvm.org/D7525

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list