r227861 - When generating llvm.used, we may need an addrspacecast instead of a bitcast.

Hans Wennborg hans at chromium.org
Wed Feb 4 12:46:24 PST 2015


On Wed, Feb 4, 2015 at 11:52 AM, Justin Holewinski
<jholewinski at nvidia.com> wrote:
> On Wed, 2015-02-04 at 11:42 -0800, Hans Wennborg wrote:
>> On Mon, Feb 2, 2015 at 1:05 PM, Justin Holewinski
>> <jholewinski at nvidia.com> wrote:
>> > Author: jholewinski
>> > Date: Mon Feb  2 15:05:49 2015
>> > New Revision: 227861
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=227861&view=rev
>> > Log:
>> > When generating llvm.used, we may need an addrspacecast instead of a bitcast.
>> >
>> > Summary:
>> > This is especially important for targets that use multiple address spaces,
>> > and commonly place global variables in address spaces other than zero.
>> >
>> > Fixes PR22383
>> >
>> > Test Plan: New test case added: llvm-used.cu
>> >
>> > Reviewers: jingyue
>> >
>> > Subscribers: llvm-commits
>> >
>> > Differential Revision: http://reviews.llvm.org/D7345
>>
>> Is this something we should merge to the 3.6 branch?
>
> Very likely, yes.  Though it should only affect targets that make use of
> non-zero address spaces, like NVPTX and R600.

I've merged it in r228185.

Thanks,
Hans



More information about the cfe-commits mailing list