[PATCH] [clang-tidy] Checker for inefficient use of algorithms on associative containers

Alexander Kornienko alexfh at google.com
Wed Feb 4 11:46:19 PST 2015


One nit, otherwise looks good. Please address the issue and I can commit the patch for you.

BTW, I think that it makes sense for you to apply for a commit access (http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access).

Also, could you run the check on LLVM/Clang to see whether it finds something?


================
Comment at: clang-tidy/misc/InefficientAlgorithmCheck.cpp:42
@@ +41,3 @@
+                              hasDeclaration(equalsBoundNode("IneffContObj")),
+                              anyOf(hasType(ContainerMatcher),
+                                    hasType(pointsTo(ContainerMatcher))))))))),
----------------
Do you need to check this in addition to the equalsBoundNode above?

http://reviews.llvm.org/D7246

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list