[PATCH] Port test/Driver/mg.c to use FileCheck instead of fgrep

[Jonathan Roelofs]

On 2/4/15 10:01 AM, Ben Langmuir wrote:
>> Index: llvm/tools/clang/test/Driver/mg.c
>> ===================================================================
>> --- llvm.orig/tools/clang/test/Driver/mg.c
>> +++ llvm/tools/clang/test/Driver/mg.c
>> @@ -1,5 +1,5 @@
>> -// RUN: %clang -M -MG -include nonexistent-preinclude.h %s > %t
>> -// RUN: grep -F nonexistent-preinclude.h %t
>> -// RUN: grep -F nonexistent-ppinclude.h %t
>> +// RUN: %clang -M -MG -include nonexistent-preinclude.h %s 2>&1 | FileCheck %s
>> +// CHECK: nonexistent-preinclude.h
>> +// CHECK: nonexistent-ppinclude.h
>>
>>   #include "nonexistent-ppinclude.h”
>
>
> Is there a reason you’ve redirected stderr to stdout?  The original test only checked stdout and there shouldn’t be anything on stderr.
I think the new version is better... It at least checks that there's no 
stderr output before what the test actually looks for.

Jon

>
>> On Feb 4, 2015, at 8:50 AM, İsmail Dönmez <ismail at donmez.ws> wrote:
>>
>> ping^4
>>
>> Refreshed against trunk now.
>>
>> On Tue, Dec 9, 2014 at 11:54 AM, İsmail Dönmez <ismail at donmez.ws> wrote:
>>> This test is the only one still using fgrep. Attached patch uses FileCheck
>>> instead of fgrep.
>>>
>>>
>> <fgrep.patch>_______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>

-- 
Jon Roelofs
jonathan at codesourcery.com
CodeSourcery / Mentor Embedded