[PATCH] Split unwind register save/restore files per-function, and appease the assembler.

[Saleem Abdulrasool]

================
Comment at: Unwind/CMakeLists.txt:25
@@ -15,1 +24,3 @@
+  UnwindRegistersSave_saveiWMMX.S
+  UnwindRegistersSave_unw_getcontext.S
 )
----------------
It would be nice to split these on architecture boundary and keep the variants in a single file.  Something like:

    UnwindRegistersRestore-${ARCH}.S
    UnwindRegistersSave-${ARCH}.S

Might be nice to do that for the current save/restore file as a setup change.

================
Comment at: Unwind/CMakeLists.txt:46
@@ -34,3 +45,3 @@
 
-append_if(LIBCXXABI_HEADERS APPLE ../../include/mach-o/compact_unwind_encoding.h)
+#append_if(LIBCXXABI_HEADERS APPLE ../../include/mach-o/compact_unwind_encoding.h)
 
----------------
I think you didn't mean for this to be part of the change.

================
Comment at: Unwind/UnwindRegistersRestore_restoreCoreAndJumpTo.S:14
@@ +13,3 @@
+
+#if __arm__ && !__APPLE__
+
----------------
Since we effectively never assembly this file in the `__APPLE__` case anyways, why not change the build system to only assembly this file if APPLE (and similar through out which won't be needed if we do the single file per arch).

================
Comment at: Unwind/UnwindRegistersRestore_restoreCoreAndJumpTo.S:16
@@ +15,3 @@
+
+#if !defined(__ARM_ARCH_ISA_ARM)
+  .thumb
----------------
Why not make this more explicit:

    #if defined(__ARM_ARCH_ISA_THUMB)
      .thumb
    #elif defined(__ARM_ARCH_ISA_ARM)
      .arm
    #else
      #error unsupported ARM ISA
    #endif

And similar through out which won't be needed if we do the single file per arch.

http://reviews.llvm.org/D7258

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/