[PATCH] [clang] Use -android environment for all compiler-rt libs.

Dan Albert danalbert at google.com
Wed Jan 28 11:18:34 PST 2015


In http://reviews.llvm.org/D7187#113850, @eugenis wrote:

> I suggest moving this logic into getCompilerRT and getting rid of the Env argument.
>
> Beside the two functions this patch is changing, getCompilerRT is used in some MSVC-specific code which can not have llvm::Triple::Android, and it addSanitizerDynamicList.
>
> The latter is interesting, because the current code is wrong, and the proposed change would fix it. Dot-sym files for android static runtime libraries are already generated with "-android" suffix, and the current implementation would fail to find them. There is no way to test it because android target defaults to shared runtime and there is no -static-libasan flag (as a counterpart to -shared-libasan).


Ah. I had avoided moving the logic into `getCompilerRT` because I thought the dynamic lists were supposed to be shared across the platforms. Should be correct now.


http://reviews.llvm.org/D7187

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list