r227069 - Reword comment.

Nico Weber nicolasweber at gmx.de
Sun Jan 25 19:03:49 PST 2015


Author: nico
Date: Sun Jan 25 21:03:49 2015
New Revision: 227069

URL: http://llvm.org/viewvc/llvm-project?rev=227069&view=rev
Log:
Reword comment.

Modified:
    cfe/trunk/test/CodeGenCXX/apple-kext-indirect-call.cpp
    cfe/trunk/test/CodeGenCXX/apple-kext-indirect-virtual-dtor-call.cpp

Modified: cfe/trunk/test/CodeGenCXX/apple-kext-indirect-call.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/apple-kext-indirect-call.cpp?rev=227069&r1=227068&r2=227069&view=diff
==============================================================================
--- cfe/trunk/test/CodeGenCXX/apple-kext-indirect-call.cpp (original)
+++ cfe/trunk/test/CodeGenCXX/apple-kext-indirect-call.cpp Sun Jan 25 21:03:49 2015
@@ -28,10 +28,9 @@ struct SubTempl : public Templ<T> {
 
 void f(SubTempl<int>* t) {
   // Qualified calls go through the (qualified) vtable in apple-kext mode.
-  // Since t's this pointer points to SubTempl's vtable, this call needs
-  // to load Templ<int>'s vtable, so that needs to be defined in this TU,
-  // which in turn means that Templ<int>::g needs to be instantiated in this TU,
-  // for it's referenced by the vtable.
+  // Since t's this pointer points to SubTempl's vtable, the call needs
+  // to load Templ<int>'s vtable.  Hence, Templ<int>::g needs to be
+  // instantiated in this TU, for it's referenced by the vtable.
   // (This happens only in apple-kext mode; elsewhere virtual calls can always
   // use the vtable pointer off this instead of having to load the vtable
   // symbol.)

Modified: cfe/trunk/test/CodeGenCXX/apple-kext-indirect-virtual-dtor-call.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/apple-kext-indirect-virtual-dtor-call.cpp?rev=227069&r1=227068&r2=227069&view=diff
==============================================================================
--- cfe/trunk/test/CodeGenCXX/apple-kext-indirect-virtual-dtor-call.cpp (original)
+++ cfe/trunk/test/CodeGenCXX/apple-kext-indirect-virtual-dtor-call.cpp Sun Jan 25 21:03:49 2015
@@ -33,10 +33,9 @@ struct SubTempl : public Templ<T> {
 
 void f(SubTempl<int>* t) {
   // Qualified calls go through the (qualified) vtable in apple-kext mode.
-  // Since t's this pointer points to SubTempl's vtable, this call needs
-  // to load Templ<int>'s vtable, so that needs to be defined in this TU,
-  // which in turn means that Templ<int>::g needs to be instantiated in this TU,
-  // for it's referenced by the vtable.
+  // Since t's this pointer points to SubTempl's vtable, the call needs
+  // to load Templ<int>'s vtable.  Hence, Templ<int>::g needs to be
+  // instantiated in this TU, for it's referenced by the vtable.
   // (This happens only in apple-kext mode; elsewhere virtual calls can always
   // use the vtable pointer off this instead of having to load the vtable
   // symbol.)





More information about the cfe-commits mailing list