[PATCH] [libcxxabi] Teach CMake better ways to find the libc++ source directory (and misc cleanup).
eric at efcs.ca
Thu Jan 22 10:42:44 PST 2015
Address @jroelofs comments.
Comment at: CMakeLists.txt:149
@@ +148,3 @@
+if (LIBCXXABI_LIBCXX_PATH STREQUAL "LIBCXXABI_LIBCXX_PATH-NOTFOUND")
+ message(WARNING "LIBCXXABI_LIBCXX_PATH was not specified and couldn't be infered.")
+ set(LIBCXXABI_LIBCXX_PATH "")
> shouldn't this be an error?
Probably not. Currently we only need the libc++ source directory if we run the tests. Otherwise finding the headers is enough to just build it. If we make this an error we lose the ability to build libc++abi without the libc++ sources.
More information about the cfe-commits