[PATCH] [Clang Tidy]: Use shrink_to_fit instead of copy and swap trick.

Gábor Horváth xazax.hun at gmail.com
Thu Jan 22 06:50:32 PST 2015


Thank you for the review!

- I have modified the doxygen documentation as you recommended.
- The actual language options are used.
- No warnings should be generated for files that compiled without C++11 support (although I am not sure that this method works for headers in general).
- Fixed the warning string and removed the redundant empty statement.
- Do not try to fix code that is the result of a macro expansion (I am not sure that my solution is idiomatic).
- Added pointer support.
- Fixed some style issues.


http://reviews.llvm.org/D7087

Files:
  clang-tidy/readability/CMakeLists.txt
  clang-tidy/readability/ReadabilityTidyModule.cpp
  clang-tidy/readability/ShrinkToFitCheck.cpp
  clang-tidy/readability/ShrinkToFitCheck.h
  test/clang-tidy/readability-shrink-to-fit.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7087.18615.patch
Type: text/x-patch
Size: 8996 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150122/a77be919/attachment.bin>


More information about the cfe-commits mailing list