[patch][rfc] Emit DeferredDeclsToEmit in order
richard at metafoo.co.uk
Wed Jan 21 16:17:57 PST 2015
On Wed, Jan 21, 2015 at 4:12 PM, Rafael Espíndola
<rafael.espindola at gmail.com> wrote:
> On 21 January 2015 at 16:25, Richard Smith <richard at metafoo.co.uk> wrote:
>> You lose one nice property of the current model: if we emit 'f', and
>> 'f' calls 'g', we then immediately emit 'g' as well. I think it'd be
>> nicer to emit declarations in something like depth-first usage order.
>> (Something like: swap DeferredDeclsToEmit with a local, then walk it
>> emitting decls, and after each one, recursively call
>> emitCurrentDeferredDecls if DeferredDeclsToEmit isn't empty.)
> I like it!
> What do you think of the attached patch?
Code change LGTM (typo "convinient")
(I've not looked through all the test changes but the ones I looked
through look like improvements.)
More information about the cfe-commits