r225196 - Fix lit for builds under /opt

[Francisco Lopes]

The commit comment was not the best. I meant it to fix *running tests*
under /opt, not *builds*.

2015-01-21 18:50 GMT-02:00 Francisco Lopes <
francisco.mailing.lists at oblita.com>:

> Hi Nick,
>
>
> I didn't get what you mean exactly. Do you want just the FIXME comment
> back?
>
> Locally at my machine I've all llvm/clang/etc sources under /opt/src/llvm.
> I had
> to use lit for the first time and it was a headache to find why nothing
> worked.
>
> This small fix made lit works without problems, with all the stuff under
> /opt/src/llvm.
>
> Although, I've used it to run clang tests solely (under
> /opt/src/llvm/tools/clang/test).
>
> Since it's having no issues with tests files under /opt anymore, I'm not
> getting why the
> FIXME note is still needed and what the file list you have shown means.
>
> Regards,
> Francisco Lopes
>
>
> 2015-01-21 18:33 GMT-02:00 Nick Lewycky <nlewycky at google.com>:
>
> On 5 January 2015 at 11:59, Francisco Lopes da Silva <oblita at gmail.com>
>> wrote:
>>
>>> Author: francisco.lopes
>>> Date: Mon Jan  5 13:59:24 2015
>>> New Revision: 225196
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=225196&view=rev
>>> Log:
>>> Fix lit for builds under /opt
>>>
>>> Modified:
>>>     cfe/trunk/test/lit.cfg
>>>
>>> Modified: cfe/trunk/test/lit.cfg
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/lit.cfg?rev=225196&r1=225195&r2=225196&view=diff
>>>
>>> ==============================================================================
>>> --- cfe/trunk/test/lit.cfg (original)
>>> +++ cfe/trunk/test/lit.cfg Mon Jan  5 13:59:24 2015
>>> @@ -306,14 +306,14 @@ tool_dirs = os.path.pathsep.join((clang_
>>>  # For example, don't match 'clang-check-' or '.clang-format'.
>>>  NoPreHyphenDot = r"(?<!(-|\.))"
>>>  NoPostHyphenDot = r"(?!(-|\.))"
>>> +NoPostBar = r"(?!(/|\\))"
>>>
>>>  for pattern in [r"\bFileCheck\b",
>>>                  r"\bc-index-test\b",
>>>                  NoPreHyphenDot + r"\bclang-check\b" + NoPostHyphenDot,
>>>                  NoPreHyphenDot + r"\bclang-format\b" + NoPostHyphenDot,
>>>                  NoPreHyphenDot + r"\bclang-interpreter\b" +
>>> NoPostHyphenDot,
>>> -                # FIXME: Some clang test uses opt?
>>> -                NoPreHyphenDot + r"\bopt\b" + NoPostHyphenDot,
>>> +                NoPreHyphenDot + r"\bopt\b" + NoPostBar +
>>> NoPostHyphenDot,
>>>
>>
>> Hrm? Clang tests still aren't supposed to be using opt. Please put the
>> fixme back?
>>
>> The list appears to be:
>>  - CodeGen/packed-structure.c
>>  - CodeGenCXX/for-range.cpp
>>  - CodeGen/mozilla-ms-inline-asm.c
>>  - CodeGen/2005-09-24-AsmUserPrefix.c
>>  - CodeGenCXX/for-range-temporaries.cpp
>>  - CodeGen/2008-07-17-no-emit-on-error.c
>>  - CodeGen/2005-06-15-ExpandGotoInternalProblem.c
>>
>> Nick
>>
>>                  # Handle these specially as they are strings searched
>>>                  # for during testing.
>>>                  r"\| \bcount\b",
>>>
>>>
>>> _______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>>
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150121/4b2a3b25/attachment.html>