[patch] If a function decl cannot be merged, mark it as invalid.

Manuel Klimek klimek at google.com
Tue Jan 20 07:08:13 PST 2015

On Tue Jan 20 2015 at 4:05:37 PM Nico Weber <thakis at chromium.org> wrote:

> On Tue, Jan 20, 2015 at 5:46 AM, Manuel Klimek <klimek at google.com> wrote:
>> On Fri Jan 16 2015 at 11:00:06 PM Nico Weber <thakis at chromium.org> wrote:
>>> On Fri, Jan 16, 2015 at 1:52 PM, Reid Kleckner <rnk at google.com> wrote:
>>>> On Fri, Jan 16, 2015 at 1:13 PM, Nico Weber <thakis at chromium.org>
>>>> wrote:
>>>>> ps: I tried to upload this to phab since this looks like the type of
>>>>> patch it's good for, but it didn't want to accept
>>>>> richard at metafoo.co.uk (or richard-llvm at metafoo.co.uk) in the
>>>>> "Reviewers" field; there also weren't any "Richard Smith"s in the
>>>>> autocomplete field :-/
>>>> Phab usually wants svn committer ids, like rnk, rsmith, thakis,
>>>> compnerd, etc.
>>> Aha, thanks! Phab does seem to know that "rsmith" is also called
>>> "Richard Smith", at least it shows that in parens in the autocomplete menu.
>>> It'd be cool if it could autocomplete "rsmith" if I type in "Richard
>>> Smith", given that it has the data for that. Manuel, could you route that
>>> upstream?
>> When I type "Richard " in the reviewer box I get "rsmith (Richard Smith)"
>> as one of the proposals; is that not what you're seeing?
> Correct, that was not what I'm seeing. I still don't get rsmith for just
> "Richard" (a few other Richards pop up). I do now get rsmith for "Richard
> Smith" – maybe it treats names used previously in a different way?

I don't get rsmith for "Richard" either, but for "Richard " (Richard space)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150120/f055f738/attachment.html>

More information about the cfe-commits mailing list