[clang] Patch for 6037

Richard Smith richard at metafoo.co.uk
Fri Jan 16 17:24:32 PST 2015

On Fri, Jan 16, 2015 at 11:49 AM, Nathan Sidwell <nathan at acm.org> wrote:
> On 01/14/15 23:11, Richard Smith wrote:
>> +typedef std::set<QualType, QualTypeOrdering> IndirectBaseSet;
>> Use llvm::SmallPtrSet rather than std::set here. Other than that, just
>> some typographical comments:
> Thanks for review. This version moves to a SmallPtrSet and addresses your
> other comments.  I hope.
> ok?

LGTM. Please convert tabs to spaces prior to commit (there are about
half a dozen lines with hard tabs in this patch), and put this { on
the previous line:

+NoteIndirectBases(ASTContext &Context, IndirectBaseSet &Set,
+  const QualType &Type)

More information about the cfe-commits mailing list