[PATCH] Improve diagnostics for asm immediate constraints and downgrade from error to default-error

[Joerg Sonnenberger]

Hi compnerd, chandlerc, rnk,

After r225244 clang verifies that inline asm constraints for immediate operands are used with ICE. This breaks existing code like pixman and tomcrypt as well as makes it impossible to create optimal output if either fixed or variable arguments can be supported. The backend has to be able to deal with the constraint check anyway and for all given cases it does. Therefore, downgrade the diagnostic from a hard error to an error-default warning. Correct use involving __builtin_constant_p can be annotated accordingly.

http://reviews.llvm.org/D7014

Files:
  include/clang/Basic/DiagnosticGroups.td
  include/clang/Basic/DiagnosticSemaKinds.td
  lib/Sema/SemaStmtAsm.cpp
  test/Sema/inline-asm-validate-x86.c

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7014.18299.patch
Type: text/x-patch
Size: 5344 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150116/949230e5/attachment.bin>