[patch] Remove ASTConsumer::HandleVTable()'s bool parameter
thakis at chromium.org
Wed Jan 14 20:09:00 PST 2015
On Wed, Jan 14, 2015 at 4:41 PM, Reid Kleckner <rnk at google.com> wrote:
> On Mon, Jan 12, 2015 at 8:17 PM, Nico Weber <thakis at chromium.org> wrote:
>> sema calls HandleVTable() with a bool parameter which is then threaded
>> through three layers. The only effect of this bool is an early return at
>> the last layer.
>> Instead, remove this parameter and call HandleVTable() only if the bool
>> is true. No intended behavior change, this is just a code simplification.
>> I'm not sure why these three hops are done – it's not due to code rot,
>> this was added in one piece in r103718. That's why I'm not just landing
>> this but asking for precommit review – does anyone know if there's a reason
>> for the current path?
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits