r225958 - Use the integrated assembler by default on 32-bit PowerPC and SPARC.

[Brad Smith]

On 01/14/15 20:59, Chandler Carruth wrote:
>
> On Wed, Jan 14, 2015 at 5:46 PM, Brad Smith <brad at comstyle.com
> <mailto:brad at comstyle.com>> wrote:
>
>     On 01/14/15 14:45, Chandler Carruth wrote:
>
>         Brad, I think it is completely unacceptable to change the default
>         assembler behavior of every OS that delegates to Generic_GCC
>         without any
>         warning, heads up email, or discussion on the lists.
>
>
>     It was on the list for everyone to see. It isn't as if its hiding.
>
>
> You submitted it without review, which means no one had a chance to see
> and comment. I specifically asked for a discussion on the mailing lists.
> If you want to change the behavior of all the OSes using this, then you
> at least need to *ask* whether the maintainers there want the change.

And you're asking after the fact. I'm not a mind reader to know about
this wishy washy process. The previous diffs were ok'd by two other
developers without any mentioning of this. In the past when I floated a
similar diff and was told that I should be enabling it everywhere. If
they knew this is what is expected then they should have said something
not to ok the diff making me think its ok to move forward.

>
>
>         It is especially unacceptable to do so when there are active
>         problems on
>         build bots and the tests aren't passing. This wasn't the first
>         time this
>         patch caused a problem either, and you are forcing several other
>         developers to chase down build bot failures.
>
>
>     What build bot failures? I haven't seen any and with the first patch I
>     did.
>
>
> Duncan cited bot failures when he reverted the patch the first time and
> Rafael pointed to an openbsd build bot failure. While I don't have the
> links handy, I don't think they were making them up.

Yes, that was the first revision. The failing tests were fixed mostly by
Ulrich when I pointed out that the 64-bit PowerPC integrater assembler
was missed being enabled in the LLVM backend by Eric Christopher with
the Clang front end bits being commited and the rest by me. The second
revision was ok'd with the intent that the tests are passing and they
are.

No tests are failing at the moment even on the PowerPC build bots..

http://lab.llvm.org:8011/builders/ppc64le-llvm/builds/59
http://lab.llvm.org:8011/builders/ppc64le-clang/builds/40


-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.