r225958 - Use the integrated assembler by default on 32-bit PowerPC and SPARC.

Brad Smith brad at comstyle.com
Wed Jan 14 17:46:41 PST 2015

On 01/14/15 14:45, Chandler Carruth wrote:
> Brad, I think it is completely unacceptable to change the default
> assembler behavior of every OS that delegates to Generic_GCC without any
> warning, heads up email, or discussion on the lists.

It was on the list for everyone to see. It isn't as if its hiding.

> It is especially unacceptable to do so when there are active problems on
> build bots and the tests aren't passing. This wasn't the first time this
> patch caused a problem either, and you are forcing several other
> developers to chase down build bot failures.

What build bot failures? I haven't seen any and with the first patch I
did. All of the tests that were having issues in the first place are

> Brad, please get explicit approval before committing again, get approval
> from maintainers of all the impacted OSes, and ensure you track all the
> build bots for regressions. When changing the driver's behavior on many
> different OSes, this kind of careful and diligent testing is absolutely
> necessary.

I haven't seen any failures from the build bots and I was watching them.

This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

More information about the cfe-commits mailing list