[PATCH] Warn about dllexported explicit class template instantiation declarations (PR22035)

Hans Wennborg hans at chromium.org
Wed Jan 14 16:53:53 PST 2015


Hi majnemer, rnk,

Clang would previously become confused and crash here.

It does not make a lot of sense to export these, so warning seems appropriate.

MSVC will export some member functions for this kind of specializations, whereas MinGW ignores the dllexport-edness. The latter behaviour seems better.

http://reviews.llvm.org/D6984

Files:
  include/clang/Basic/DiagnosticSemaKinds.td
  lib/Sema/SemaDeclCXX.cpp
  lib/Sema/SemaTemplate.cpp
  test/CodeGenCXX/dllexport.cpp
  test/SemaCXX/dllexport.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6984.18196.patch
Type: text/x-patch
Size: 6626 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150115/25d98f84/attachment.bin>


More information about the cfe-commits mailing list