[PATCH] [libcxx] SFINAE-friendly common_type

Agustín Bergé kaballo86 at hotmail.com
Wed Jan 14 05:51:01 PST 2015

Comment at: include/type_traits:216
@@ -215,3 +215,3 @@
 template <class...> 
 struct __void_t { typedef void type; };
This patch seems to be the first to make use of `__void_t`. I would rather have this named `__void` instead as it is not an alias, would that name potentially clash?

Comment at: include/type_traits:1489
@@ +1488,3 @@
+template <class ...Tp> struct __common_types;
Here `__common_types` is used merely to carry a pack of types, very much like the existing `__tuple_types`. Perhaps a generic one could be introduced to replace both uses.



More information about the cfe-commits mailing list