[PATCH] [mips] Handle transparent unions correctly.

Simon Atanasyan simon at atanasyan.com
Wed Jan 14 02:56:08 PST 2015


LGTM (with a nit).


================
Comment at: lib/CodeGen/TargetInfo.cpp:5706
@@ -5705,1 +5705,3 @@
 
+  Ty = useFirstFieldIfTransparentUnion(Ty);
+
----------------
I would move this call to the first line of the `MipsABIInfo::classifyArgumentType` function to be sure that all subsequent actions deal with updated `Ty`.

http://reviews.llvm.org/D6963

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list