[PATCH] Implementation for completion in call context for C++

Francisco Lopes francisco.mailing.lists at oblita.com
Tue Jan 13 12:12:29 PST 2015

Thanks for the feedback Manuel,

I didn't try it in MSVC 2012, I hope it's not a hassle to compile clang in
I'm downloading the express edition so I can try it.

I believe the sole critical piece regarding the style guide is the
declaration of the
ParseExpressionList function. Although I think it's good to have the
default argument
initialized that way, which is simple and short, it may not be in
accordance with the
"Do not use Braced Initializer Lists to Call a Constructor" section of the
style guide.

As I'm unsure about this specific usage, I'll left it as is until proper

2015-01-13 17:12 GMT-02:00 Manuel Klimek <klimek at google.com>:

> General high level comment: you're using C++11 extensively, have you made
> sure you're only using features MSVC 2012 supports (as per the style guide:
> http://llvm.org/docs/CodingStandards.html)?
> http://reviews.llvm.org/D6880
>   http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150113/3fddb930/attachment.html>

More information about the cfe-commits mailing list