[PATCH] More robust deployment target parsing on darwin
    Tim Northover 
    t.p.northover at gmail.com
       
    Tue Jan 13 10:35:56 PST 2015
    
    
  
Hi Steven,
This mostly looks fine; just one comment:
On 12 January 2015 at 15:00, Steven Wu <stevenwu at apple.com> wrote:
> +        if (BeginSDK != std::string::npos && EndSDK != std::string::npos) {
These should probably be using StringRef::npos, since under a fairly
bizarre set of circumstances it may differ from std::string::npos.
Tim.
    
    
More information about the cfe-commits
mailing list