[PATCH] Insert random noops to increase security against ROP attacks (clang)

JF Bastien jfb at chromium.org
Mon Jan 12 17:05:32 PST 2015


On Mon, Jan 12, 2015 at 2:57 PM, Chandler Carruth <chandlerc at google.com>
wrote:

>
> On Mon, Jan 12, 2015 at 12:52 PM, JF Bastien <jfb at chromium.org> wrote:
>
>> No comments yet, I'm going to assume this is good to go and commit it
>> soon.
>
>
> JF, this isn't the code review process. Please wait for an actual LGTM
> prior to committing code.
>

Sorry for the confusion, Chandler and I discussed this offline: I'm
LGTM'ing the change Stephen authored, and leaving it open to anyone else to
comment (which nobody has yet). To further confuse things I'm the one
committing this for Stephen because he doesn't have commit access (which we
should remedy!). So, I will go ahead and commit Stephen's change soon, and
try to not confuse people next time :-)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150112/949e07a7/attachment.html>


More information about the cfe-commits mailing list