[patch][pr19848] Produce explicit comdats in clang

David Majnemer david.majnemer at gmail.com
Mon Jan 12 13:24:10 PST 2015

Please use llvm_unreachable at the bottom of shouldBeInCOMDAT, gcc warns
otherwise. LGTM.

On Thu, Jan 8, 2015 at 6:00 AM, Rafael EspĂ­ndola <rafael.espindola at gmail.com
> wrote:

> On 8 January 2015 at 03:42, David Majnemer <david.majnemer at gmail.com>
> wrote:
> > I don't think we'd want to keep marking C++ entities as
> weak/linkonce/etc.
> > in the MSVC ABI if we are splitting the COMDATness out.  I guess we still
> > sorta need it to talk about the discardability of a symbol...
> And that should really be an independent patch, no? It is basically
> the "splitting linkage" discussion and it is larger than this.
> Cheers,
> Rafael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150112/57aba52c/attachment.html>

More information about the cfe-commits mailing list