r225000 - Reapply "DebugInfo: Generalize debug info location handling"

Adrian Prantl aprantl at apple.com
Fri Jan 9 14:26:52 PST 2015


> Try it - it shouldn't assert. The assertion only fires when the caller has debug info as well.

Interesting! I tried a triple-nested call were the middle function was without debug info and the inlined instructions from the function without debug info get re-parented into the callee function and it works out. Sweet.

I’m retracting my concerns. I will look into fixing CFE to emit valid DebugLocs inside the landingpad.


> 1) a function with debug info calls
> 2) a function with instructions with debuglocs (not necessarily a function with debug info - it could be a nodebug function that's had debug functions inlined into it already) through
> 3) a call without a debug location

Could you craft this into an assertion and add it — maybe to the inliner? Alternatively, could you add this as a comment next to the assertion?

thanks,
adrian



More information about the cfe-commits mailing list