[Patch][ObjC][Proposal] NSValue literals

[AlexDenisov]

We may not support boxing of any pointer types after all 
(as the underlying API does not manage the collected object).
So, final patch may need to address that.
No problem. To be honest, I don’t see real benefits of having such ability, it was a silly decision to include this functionality (motivated by ‘because I can’).

Please provide more tests 
for NSEdgeInsets and specifically, see that diagnostics come out when 
deployment target does not support it.
What kind of tests should I add? It has tests for Sema and CodeGen, did I forget/missed something?

Please hang on to the patch until we have gone through
the language review process.
Got it!

-- 
AlexDenisov
Software Engineer, https://github.com/AlexDenisov

On 9 Jan 2015 at 20:14:47, jahanian (fjahanian at apple.com) wrote:


We may not support boxing of any pointer types after all 
(as the underlying API does not manage the collected object).
So, final patch may need to address that. Please provide more tests 
for NSEdgeInsets and specifically, see that diagnostics come out when 
deployment target does not support it.
Otherwise, patch looks good. Please hang on to the patch until we have gone through
the language review process.

- Thanks, Fairborz


On Jan 6, 2015, at 10:23 AM, AlexDenisov <1101.debian at gmail.com> wrote:

Thank you for response. 
I already sent another patch, it could be found here: 
http://article.gmane.org/gmane.comp.compilers.clang.scm/114023

-- 
AlexDenisov
Software Engineer, https://github.com/AlexDenisov

On 5 Jan 2015 at 19:39:16, jahanian (fjahanian at apple.com) wrote:


On Dec 24, 2014, at 3:29 AM, AlexDenisov <1101.debian at gmail.com> wrote:

Do the usual lookup to find the method which implements this syntax. Call Decl::getAvailability on this method. If it returns
anything other than AvailabilityResult::AR_Available 
Well, I understand this part, it’s pretty obvious. But what I don’t understand is:

issue an appropriate diagnostic.
What is appropriate diagnostic for AR_NotYetIntroduced?

Should I introduce this diagnostic? Or just show warning/error for Deprecated/Unavailable and ignore NotYetIntroduced AR?

It is sufficient to issue an unavailability diagnostics since diagnostic points to the method which has the availability info. as part of its declaration.

- Fariborz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150109/1ee1fb2b/attachment.html>